[
https://issues.apache.org/jira/browse/HDFS-13603?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17850503#comment-17850503
]
ASF GitHub Bot commented on HDFS-13603:
---------------------------------------
simbadzina commented on code in PR #6774:
URL: https://github.com/apache/hadoop/pull/6774#discussion_r1619473416
##########
hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/crypto/key/TestValueQueue.java:
##########
@@ -111,6 +119,40 @@ public void testWarmUp() throws Exception {
vq.shutdown();
}
+ /**
+ * Verifies that Queue is initialized (Warmed-up) for partial keys
+ */
+ @Test(timeout = 30000)
+ public void testPartialWarmUp() throws Exception {
+ MockFiller filler = new MockFiller();
+ ValueQueue<String> vq =
+ new ValueQueue<>(10, 0.5f, 30000, 1,
+ SyncGenerationPolicy.ALL, filler);
+
+ @SuppressWarnings("unchecked")
+ LoadingCache<String,
LinkedBlockingQueue<KeyProviderCryptoExtension.EncryptedKeyVersion>> kq =
+ (LoadingCache<String,
LinkedBlockingQueue<KeyProviderCryptoExtension.EncryptedKeyVersion>>)
+ FieldUtils.getField(ValueQueue.class, "keyQueues", true).get(vq);
+
+ LoadingCache<String,
LinkedBlockingQueue<KeyProviderCryptoExtension.EncryptedKeyVersion>> kqSpy =
spy(kq);
Review Comment:
[ERROR]
/Users/sdzinama/dev/hadooptree/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/crypto/key/TestValueQueue.java:137:
Line is longer than 100 characters (found 110). [LineLength]
> Warmup NameNode EDEK thread retries continuously if there's an invalid key
> ---------------------------------------------------------------------------
>
> Key: HDFS-13603
> URL: https://issues.apache.org/jira/browse/HDFS-13603
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: encryption, namenode
> Affects Versions: 2.8.0
> Reporter: Antony Jay
> Priority: Major
> Labels: pull-request-available
>
> https://issues.apache.org/jira/browse/HDFS-9405 adds a background thread to
> pre-warm EDEK cache.
> However this fails and retries continuously if key retrieval fails for one
> encryption zone. In our usecase, we have temporarily removed keys for certain
> encryption zones. Currently namenode and kms log is filled up with errors
> related to background thread retrying warmup for ever .
> The pre-warm thread should
> * Continue to refresh other encryption zones even if it fails for one
> * Should retry only if it fails for all encryption zones, which will be the
> case when kms is down.
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
