[
https://issues.apache.org/jira/browse/HDFS-17565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17864061#comment-17864061
]
ASF GitHub Bot commented on HDFS-17565:
---------------------------------------
ayushtkn commented on code in PR #6928:
URL: https://github.com/apache/hadoop/pull/6928#discussion_r1669988397
##########
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataNode.java:
##########
@@ -1079,6 +1084,22 @@ private String
reconfSlowIoWarningThresholdParameters(String property, String ne
}
}
+ private String reconfStripedReconstructionParameters(String property, String
newVal)
+ throws ReconfigurationException {
+ String result = null;
+ try {
+ if (property.equals(DFS_DN_EC_RECONSTRUCTION_THREADS_KEY)) {
Review Comment:
do we need this if condition? it would be always true?
##########
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataNode.java:
##########
@@ -1079,6 +1084,22 @@ private String
reconfSlowIoWarningThresholdParameters(String property, String ne
}
}
+ private String reconfStripedReconstructionParameters(String property, String
newVal)
+ throws ReconfigurationException {
+ String result = null;
+ try {
+ if (property.equals(DFS_DN_EC_RECONSTRUCTION_THREADS_KEY)) {
+ int size = (newVal == null ? DFS_DN_EC_RECONSTRUCTION_THREADS_DEFAULT :
+ Integer.parseInt(newVal));
+ result = Long.toString(size);
Review Comment:
what are we doing here? converting newVal to Integer & then again converting
into string? shouldn't we just check null & directly pass the string, rather
than this conversion
> EC: dfs.datanode.ec.reconstruction.threads should support dynamic
> reconfigured.
> -------------------------------------------------------------------------------
>
> Key: HDFS-17565
> URL: https://issues.apache.org/jira/browse/HDFS-17565
> Project: Hadoop HDFS
> Issue Type: Improvement
> Reporter: Chenyu Zheng
> Assignee: Chenyu Zheng
> Priority: Major
> Labels: pull-request-available
>
> dfs.datanode.ec.reconstruction.threads should support dynamic reconfigured,
> then we can adjust the speed of ec block copy. Especially HDFS-17550 wanna
> decommissioning DataNode by EC block reconstruction.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
