[
https://issues.apache.org/jira/browse/HDFS-17579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17867640#comment-17867640
]
ASF GitHub Bot commented on HDFS-17579:
---------------------------------------
VicoWu commented on PR #6941:
URL: https://github.com/apache/hadoop/pull/6941#issuecomment-2241934063
@jojochuang Would you please take a look?
> [DatanodeAdminDefaultMonitor] Better Comments Explaining Why Blocks Need
> Reconstruction May Not Block Decommission/Maintenance
> ------------------------------------------------------------------------------------------------------------------------------
>
> Key: HDFS-17579
> URL: https://issues.apache.org/jira/browse/HDFS-17579
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: dfsadmin
> Reporter: wuchang
> Priority: Major
> Labels: pull-request-available
>
> Below comments for explaining why blocks which need reconstruction may not
> block decommission/maintenance is weird:
> {code:java}
> // Even if the block is without sufficient redundancy,
> // it might not block decommission/maintenance if it
> // has sufficient redundancy.
> if (dnAdmin.isSufficient(block, bc, num, isDecommission,
> isMaintenance)) {
> if (pruneReliableBlocks) {
> it.remove(); {code}
> I checked the detailed code and get the reason that why blocks which need
> reconstruction may not block decommission/maintenance, and give it a better
> comment
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
