[ 
https://issues.apache.org/jira/browse/HDFS-17575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17867737#comment-17867737
 ] 

ASF GitHub Bot commented on HDFS-17575:
---------------------------------------

szetszwo opened a new pull request, #6954:
URL: https://github.com/apache/hadoop/pull/6954

   ### Description of PR
   
   HDFS-17575
   
   This is a continue work on #6933.
   
   Currently, a SaslDataTransferClient may send a message without using its 
SaslParticipant as below.
   ```java
             sendSaslMessage(out, new byte[0]);
   ```
   Instead, it should use its SaslParticipant to create the response.
   ```java
         byte[] localResponse = 
sasl.evaluateChallengeOrResponse(remoteResponse);
         sendSaslMessage(out, localResponse);
   ```
   
   ### How was this patch tested?
   
   By existing unit tests.
   
   ### For code changes:
   
   - [X] Does the title or this PR starts with the corresponding JIRA issue id 
(e.g. 'HADOOP-17799. Your PR title ...')?
   - [NA] Object storage: have the integration tests been executed and the 
endpoint declared according to the connector-specific documentation?
   - [NA] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?
   - [NA] If applicable, have you updated the `LICENSE`, `LICENSE-binary`, 
`NOTICE-binary` files?




> SaslDataTransferClient should use SaslParticipant to create messages
> --------------------------------------------------------------------
>
>                 Key: HDFS-17575
>                 URL: https://issues.apache.org/jira/browse/HDFS-17575
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: security
>            Reporter: Tsz-wo Sze
>            Assignee: Tsz-wo Sze
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 3.5.0
>
>
> Currently, a SaslDataTransferClient may send a message without using its 
> SaslParticipant as below.  {code}
>           sendSaslMessage(out, new byte[0]);
> {code}
> Instead, it should use its SaslParticipant to create the response.
> {code}
>       byte[] localResponse = sasl.evaluateChallengeOrResponse(remoteResponse);
>       sendSaslMessage(out, localResponse);
> {code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

Reply via email to