[
https://issues.apache.org/jira/browse/HDFS-776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13205860#comment-13205860
]
Uma Maheswara Rao G commented on HDFS-776:
------------------------------------------
{quote}
The first one should be IOException, not Exception.
{quote}
Oops. its my mistake. sorry, In previous patch i made that as IOException. In
current one only forgot to change :(. Thanks a lot for noticing.I have updated
it.
{quote}
For InterruptedException, it is better to use LOG.info(..) since interrupting a
thread is a normal behavior.
{quote}
done.
Thanks a lot for review.
> Fix exception handling in Balancer
> ----------------------------------
>
> Key: HDFS-776
> URL: https://issues.apache.org/jira/browse/HDFS-776
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: balancer
> Reporter: Owen O'Malley
> Assignee: Uma Maheswara Rao G
> Priority: Critical
> Attachments: HDFS-776.0.patch, HDFS-776.patch, HDFS-776.patch,
> HDFS-776.patch, HDFS-776.patch
>
>
> The Balancer's AccessKeyUpdater handles exceptions badly. In particular:
> 1. Catching Exception too low. The wrapper around setKeys should only catch
> IOException.
> 2. InterruptedException is ignored. It should be caught at the top level and
> exit run.
> 3. Throwable is not caught. It should be caught at the top level and kill the
> Balancer server process.
> {code}
> class AccessKeyUpdater implements Runnable {
> public void run() {
> while (shouldRun) {
> try {
> accessTokenHandler.setKeys(namenode.getAccessKeys());
> } catch (Exception e) {
> LOG.error(StringUtils.stringifyException(e));
> }
> try {
> Thread.sleep(keyUpdaterInterval);
> } catch (InterruptedException ie) {
> }
> }
> }
> }
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
