[ 
https://issues.apache.org/jira/browse/HDFS-17040?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17884005#comment-17884005
 ] 

ASF GitHub Bot commented on HDFS-17040:
---------------------------------------

Galsza commented on PR #5721:
URL: https://github.com/apache/hadoop/pull/5721#issuecomment-2369152762

   Thanks for the patch, looking good to me +1
   
   I've tested this change in a cluster by trying to upload a file containing 
the text "hello %" via namenode ui. The change is indeed working. I haven't 
found a CORS related problem or at least Chrome browsers security levels don't 
seem to affect it.




> Namenode web UI should set content type to application/octet-stream when 
> uploading a file
> -----------------------------------------------------------------------------------------
>
>                 Key: HDFS-17040
>                 URL: https://issues.apache.org/jira/browse/HDFS-17040
>             Project: Hadoop HDFS
>          Issue Type: Task
>          Components: ui
>            Reporter: Attila Magyar
>            Priority: Major
>              Labels: pull-request-available
>
> When uploading a file using -WebHDFS- the Namenode web UI, it will set the 
> content type to application/x-www-form-urlencoded, as this is the default 
> used by jQuery
> https://github.com/apache/hadoop/blob/160b9fc3c9255024c00d487b7fcdf5ea59a42781/hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/hdfs/explorer.js#L516
> This causes knox to urlencode the request body so that uploading a CVS file 
> 1,2,3 will result 1%2C2%2C3.
> Instead of application/x-www-form-urlencoded I think the encoding should be 
> set to application/octet-stream.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

Reply via email to