[
https://issues.apache.org/jira/browse/HDFS-17607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17888499#comment-17888499
]
ASF GitHub Bot commented on HDFS-17607:
---------------------------------------
ThinkerLei commented on code in PR #7012:
URL: https://github.com/apache/hadoop/pull/7012#discussion_r1796360139
##########
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataStorage.java:
##########
@@ -335,7 +335,7 @@ public VolumeBuilder prepareVolume(DataNode datanode,
VolumeBuilder builder =
new VolumeBuilder(this, sd);
for (NamespaceInfo nsInfo : nsInfos) {
- location.makeBlockPoolDir(nsInfo.getBlockPoolID(), null);
+ location.makeBlockPoolDir(nsInfo.getBlockPoolID(), datanode.getConf());
Review Comment:
@Hexiaoqiao Thank you for your response. The method cannot use getDnConf
here because the type used inside the method is Configuration, not DNConf.
> Reduce the number of times conf is loaded when DataNode startUp
> ---------------------------------------------------------------
>
> Key: HDFS-17607
> URL: https://issues.apache.org/jira/browse/HDFS-17607
> Project: Hadoop HDFS
> Issue Type: Improvement
> Reporter: lei w
> Priority: Major
> Labels: pull-request-available
>
> The value of the conf parameter in the current access method
> StorageLocation#makeBlockPoolDir is null, which leads to the problem of
> loading conf multiple times when DataNode startUp
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
