[
https://issues.apache.org/jira/browse/HDFS-17646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17891159#comment-17891159
]
ASF GitHub Bot commented on HDFS-17646:
---------------------------------------
haiyang1987 commented on code in PR #7120:
URL: https://github.com/apache/hadoop/pull/7120#discussion_r1807374174
##########
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/balancer/Balancer.java:
##########
@@ -456,13 +460,20 @@ private long init(List<DatanodeStorageReport> reports) {
sortOverUtilized(overUtilizedPercentage);
}
+ // Limit the maximum number of overUtilized datanodes
+ // If excludedOverUtilizedNum is greater than 0, The overUtilized nodes
num is limited
+ int excludedOverUtilizedNum = Math.max(overUtilized.size() -
limitOverUtilizedNum, 0);
+ if (excludedOverUtilizedNum > 0) {
+ limitOverUtilizedNum();
+ }
+
logUtilizationCollections();
metrics.setNumOfOverUtilizedNodes(overUtilized.size());
metrics.setNumOfUnderUtilizedNodes(underUtilized.size());
-
- Preconditions.checkState(dispatcher.getStorageGroupMap().size()
- == overUtilized.size() + underUtilized.size() + aboveAvgUtilized.size()
- + belowAvgUtilized.size(),
+
Review Comment:
please fix checkstytle
> Add Option to limit Balancer overUtilized nodes num in each iteration.
> ----------------------------------------------------------------------
>
> Key: HDFS-17646
> URL: https://issues.apache.org/jira/browse/HDFS-17646
> Project: Hadoop HDFS
> Issue Type: New Feature
> Reporter: Zhaobo Huang
> Assignee: Zhaobo Huang
> Priority: Major
> Labels: pull-request-available
>
> Limit the maximum number of overutilized datanodes to avoid excessive nodes
> affecting cluster stability.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
