[ https://issues.apache.org/jira/browse/HDFS-17646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17893174#comment-17893174 ]
ASF GitHub Bot commented on HDFS-17646: --------------------------------------- huangzhaobo99 commented on code in PR #7120: URL: https://github.com/apache/hadoop/pull/7120#discussion_r1817983747 ########## hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/balancer/Balancer.java: ########## @@ -1071,6 +1096,12 @@ static BalancerParameters parse(String[] args) { b.setSortTopNodes(true); LOG.info("Balancer will sort nodes by" + " capacity usage percentage to prioritize top used nodes"); + } else if ("-limitOverUtilizedNum".equalsIgnoreCase(args[i])) { + Preconditions.checkArgument(++i < args.length, + "limitOverUtilizedNum value is missing: args = " + Arrays.toString(args)); + int limitNum = Integer.parseInt(args[i]); Review Comment: Fixed, 0 is legal, non-negative numbers are okay. ########## hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/balancer/BalancerParameters.java: ########## @@ -120,12 +127,12 @@ public String toString() { + " max idle iteration = %s," + " #excluded nodes = %s," + " #included nodes = %s," + " #source nodes = %s," + " #blockpools = %s," + " run during upgrade = %s," - + " sort top nodes = %s," + + " sort top nodes = %s," + " limit overUtilized nodes num = %s" Review Comment: Fixed > Add Option to limit Balancer overUtilized nodes num in each iteration. > ---------------------------------------------------------------------- > > Key: HDFS-17646 > URL: https://issues.apache.org/jira/browse/HDFS-17646 > Project: Hadoop HDFS > Issue Type: New Feature > Reporter: Zhaobo Huang > Assignee: Zhaobo Huang > Priority: Major > Labels: pull-request-available > > Limit the maximum number of overutilized datanodes to avoid excessive nodes > affecting cluster stability. -- This message was sent by Atlassian Jira (v8.20.10#820010) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org