[
https://issues.apache.org/jira/browse/HDFS-17642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17894648#comment-17894648
]
ASF GitHub Bot commented on HDFS-17642:
---------------------------------------
Jtdellaringa commented on code in PR #7127:
URL: https://github.com/apache/hadoop/pull/7127#discussion_r1824785790
##########
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/balancer/TestBalancer.java:
##########
@@ -1245,8 +1245,49 @@ public void testBalancerCliParseWithWrongParams() {
Balancer.Cli.parse(parameters);
fail(reason + " for -source parameter");
} catch (IllegalArgumentException ignored) {
- // expected
+
+ }
+
+ parameters = new String[] {"-excludeSource"};
Review Comment:
Hey @ctrezzo I have added unit tests, please take a look.
> Support specifying Datanodes to exclude for balancing at source/target
> granularity
> ----------------------------------------------------------------------------------
>
> Key: HDFS-17642
> URL: https://issues.apache.org/jira/browse/HDFS-17642
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: balancer & mover
> Reporter: Joseph Dell'Aringa
> Assignee: Joseph Dell'Aringa
> Priority: Major
> Labels: pull-request-available
>
> In some cases it can be useful to exclude a list of datanodes from being
> selected as a target but remaining an option for a source and vice-versa.
> The fix for this ticket will add an additional exclude list for source and
> target datanodes.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
