[ https://issues.apache.org/jira/browse/HDFS-17670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17899839#comment-17899839 ]
ASF GitHub Bot commented on HDFS-17670: --------------------------------------- mukund-thakur commented on code in PR #7168: URL: https://github.com/apache/hadoop/pull/7168#discussion_r1850796981 ########## hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestElasticByteBufferPool.java: ########## @@ -0,0 +1,35 @@ +package org.apache.hadoop.io; + +import org.assertj.core.api.Assertions; +import org.junit.Test; + +import java.nio.ByteBuffer; + +public class TestElasticByteBufferPool { Review Comment: You are just testing the WeakReferencedElasticByteBufferPool here as well with just using the abstract base class. I think this is just duplicate and you can just change all the instances of base class in the TestWeakReferencedElasticByteBufferPool > HDFS Client's direct memory leaks with erasure coding enabled > ------------------------------------------------------------- > > Key: HDFS-17670 > URL: https://issues.apache.org/jira/browse/HDFS-17670 > Project: Hadoop HDFS > Issue Type: Bug > Components: erasure-coding > Reporter: Eungsop Yoo > Priority: Major > Labels: pull-request-available > Attachments: image-2024-11-18-13-53-23-690.png > > > We are testing erasure coding with HBase. But we faced that the size of > direct memory of HBase RegionServer keep growing. > !image-2024-11-18-13-53-23-690.png! > It is caused by that the direct memory allocated by ElasticByteBufferPool of > HDFS client is never released. > https://issues.apache.org/jira/browse/HADOOP-18105 > We found that we already have the solution, > WeakReferencedElasticByteBufferPool. > Just replace ElasticByteBufferPool with WeakReferencedElasticByteBufferPool. -- This message was sent by Atlassian Jira (v8.20.10#820010) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org