[ 
https://issues.apache.org/jira/browse/HDFS-17609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17906617#comment-17906617
 ] 

ASF GitHub Bot commented on HDFS-17609:
---------------------------------------

ZanderXu commented on PR #7037:
URL: https://github.com/apache/hadoop/pull/7037#issuecomment-2550470220

   @hfutatzhanghb I rebased the branch HDFS-17384 based on the latest trunk, 
can you rebase this PR? Thanks 




> [FGL] Fix lock mode in some RPC
> -------------------------------
>
>                 Key: HDFS-17609
>                 URL: https://issues.apache.org/jira/browse/HDFS-17609
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>            Reporter: farmmamba
>            Assignee: farmmamba
>            Priority: Major
>              Labels: pull-request-available
>
> * FSNamesystem#getFilesBlockingDecom : use GLOBAL mode rather than FS mode 
> because of below codes:
> ```java
> for (DatanodeDescriptor dataNode :
>         blockManager.getDatanodeManager().getDatanodes()) {
> }
> ```
>  
>  * FSNamesystem#listOpenFiles: use GLOBAL mode because it calls 
> getFilesBlockingDecom method.
>  * FSNamesystem#getContentSummary: use GLOBAL mode rather than FS mode 
> because it calls computeFileSize method.
>  * BlockManagerSafeMode#leaveSafeMode: use GLOBAL mode rather than BM mode 
> because it calls startSecretManagerIfNecessary which depended upon FS lock. 
> Change to GLOBAL mode is safe here.
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

Reply via email to