[
https://issues.apache.org/jira/browse/HDFS-17683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17906903#comment-17906903
]
ASF GitHub Bot commented on HDFS-17683:
---------------------------------------
tomscut commented on code in PR #7211:
URL: https://github.com/apache/hadoop/pull/7211#discussion_r1891056796
##########
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestDataNodeMetrics.java:
##########
@@ -816,4 +817,28 @@ public Boolean get() {
}, 100, 10000);
}
}
+
+ @Test
+ public void testDataNodeDatasetLockMetrics() throws IOException {
+ Configuration conf = new HdfsConfiguration();
+ MiniDFSCluster cluster = new MiniDFSCluster.Builder(conf).build();
+ try {
Review Comment:
It's best to use `try-with-resources` here.
> Add metrics for acquiring dataset read/write lock
> -------------------------------------------------
>
> Key: HDFS-17683
> URL: https://issues.apache.org/jira/browse/HDFS-17683
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: datanode
> Reporter: farmmamba
> Assignee: farmmamba
> Priority: Major
> Labels: pull-request-available
>
> Add metrics for acquiring dataset read/write lock
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
