[ 
https://issues.apache.org/jira/browse/HDFS-17657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17908136#comment-17908136
 ] 

ASF GitHub Bot commented on HDFS-17657:
---------------------------------------

tomscut commented on code in PR #7242:
URL: https://github.com/apache/hadoop/pull/7242#discussion_r1897032050


##########
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/balancer/TestBalancerService.java:
##########
@@ -210,4 +216,49 @@ public void testBalancerServiceOnError() throws Exception {
       }
     }
   }
+
+  @Test(timeout = 60000)
+  public void testBalancerServiceMetrics() throws Exception {
+    Configuration conf = new HdfsConfiguration();
+    conf.setTimeDuration(DFSConfigKeys.DFS_BALANCER_SERVICE_INTERVAL_KEY, 5, 
TimeUnit.SECONDS);
+    TestBalancer.initConf(conf);
+    try {

Review Comment:
   It's best to use try-with-resources here. Others look good to me.





> The balancer service supports httpserver.
> -----------------------------------------
>
>                 Key: HDFS-17657
>                 URL: https://issues.apache.org/jira/browse/HDFS-17657
>             Project: Hadoop HDFS
>          Issue Type: New Feature
>            Reporter: Zhaobo Huang
>            Assignee: Zhaobo Huang
>            Priority: Minor
>              Labels: pull-request-available
>         Attachments: Figures1.png, Figures2.png
>
>
> *Background*
> At present, the balance service supports long process deployment, but does 
> not support webserver services.
> *Implement functions*
> 1.This PR mainly implements the basic capabilities of the webserver, and 
> through the UI interface, it can view metrics such as the amount of data 
> currently being migrated by the balancer process, how much data the cluster 
> still needs to migrate to reach balanced state, etc.
> 2.Reuse the basic functions of HttpServer and HTML, support view conf, 
> metrics, thread dump, etc.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

Reply via email to