[
https://issues.apache.org/jira/browse/HDFS-17328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17911875#comment-17911875
]
ASF GitHub Bot commented on HDFS-17328:
---------------------------------------
kokon191 commented on code in PR #6422:
URL: https://github.com/apache/hadoop/pull/6422#discussion_r1910066640
##########
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/diskbalancer/datamodel/DiskBalancerDataNode.java:
##########
@@ -238,6 +238,10 @@ public boolean isBalancingNeeded(double threshold) {
* @param volume - volume
*/
public void addVolume(DiskBalancerVolume volume) throws Exception {
+ addVolume(volume, false);
Review Comment:
Shouldn't the default be `true`, so `addVolume(volume, true);` instead?
> DiskBalancer should not computeNodeDensity every time when addVolume
> --------------------------------------------------------------------
>
> Key: HDFS-17328
> URL: https://issues.apache.org/jira/browse/HDFS-17328
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: diskbalancer
> Affects Versions: 3.3.6
> Reporter: farmmamba
> Assignee: farmmamba
> Priority: Major
> Labels: pull-request-available
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
