[
https://issues.apache.org/jira/browse/HDFS-17724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17923849#comment-17923849
]
ASF GitHub Bot commented on HDFS-17724:
---------------------------------------
cnauroth commented on code in PR #7348:
URL: https://github.com/apache/hadoop/pull/7348#discussion_r1941957703
##########
hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/DFSStripedOutputStream.java:
##########
@@ -1200,9 +1197,7 @@ void setClosed() {
@Override
protected synchronized void closeImpl() throws IOException {
- boolean recoverLeaseOnCloseException = dfsClient.getConfiguration()
- .getBoolean(RECOVER_LEASE_ON_CLOSE_EXCEPTION_KEY,
- RECOVER_LEASE_ON_CLOSE_EXCEPTION_DEFAULT);
+ boolean recoverLeaseOnCloseException =
dfsClient.getConfiguration().getRecoverLeaseOnCloseException();
Review Comment:
Thank you for the patch, @Abhey . Pre-submit checks show this line failing
to compile. I think you'll need to change to `dfsClient.getConf()` so that it
fetches the `DfsClientConf` instead of `Configuration`, and then it can call
your new method.
> Set recover.lease.on.close.exception as an instance member in the
> DfsClientConf.java
> ------------------------------------------------------------------------------------
>
> Key: HDFS-17724
> URL: https://issues.apache.org/jira/browse/HDFS-17724
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: hadoop-client
> Affects Versions: 3.4.1
> Reporter: Abhey Rana
> Priority: Minor
> Labels: pull-request-available
> Original Estimate: 96h
> Remaining Estimate: 96h
>
> As part of HDFS-14694. A code was introduced where-in we wer reading the
> RECOVER_LEASE_ON_CLOSE_EXCEPTION configuration directly in the
> DFSOutputStream.java.
> The DFS client has it's onw configuration class DfsClientConf and this
> confiugration should be read using the getter method of that class instead of
> directly acessing it.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
