[ https://issues.apache.org/jira/browse/HDFS-17731?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17928970#comment-17928970 ]
ASF GitHub Bot commented on HDFS-17731: --------------------------------------- KeeProMise commented on PR #7409: URL: https://github.com/apache/hadoop/pull/7409#issuecomment-2673196723 > > > Hi @hfutatzhanghb I'm not sure if need to fix checkstyle, other LGTM! > > > > > > Thanks for reviewing,maybe we can add `@SuppressWarnings("checkstyle:visibilitymodifier")` here? will try this way. > > @KeeProMise sir, green heart +1 this time. LGTM! Thanks for your contribution! > [ARR] Add unit test for async RouterAdminServer > ----------------------------------------------- > > Key: HDFS-17731 > URL: https://issues.apache.org/jira/browse/HDFS-17731 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: rbf > Affects Versions: 3.4.1 > Reporter: farmmamba > Assignee: farmmamba > Priority: Major > Labels: pull-request-available > > Add unit test for async RouterAdminServer -- This message was sent by Atlassian Jira (v8.20.10#820010) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org