[
https://issues.apache.org/jira/browse/HDFS-2928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13208551#comment-13208551
]
Uma Maheswara Rao G commented on HDFS-2928:
-------------------------------------------
Hi Aaron, Thanks a lot for the review.
{quote}
# A few lines are now well over 80 chars (some past 100)
{quote}
thanks for noticing. done, except below line
{code}
public static ClientNamenodeProtocolTranslatorPB
createNNProxyWithClientProtocol(
{code}
couldn't split this.
{quote}
# Please use javadoc-style method comments, rather than describe the parameters
in prose.
# So we don't have to change DFSClient at all, let's add another version of
DFSUtil#createNamenode which defaults the value of withRetries to "true."
{quote}
done.
{quote}
It seems odd to me that we push down withRetries all the way to
ClientNamenodeProtocolTranslatorPB in the case of the ClientProtocol, but
handle withRetries in DFSUtil in the case of NamenodeProtocol. In fact, it
seems to me that handling retry proxy setup in
ClientNamenodeProtocolTranslatorPB is probably a mistake. Could you please move
the retry proxy setup stuff in ClientNamenodeProtocolTranslatorPB into DFSUtil?
{quote}
done.
{quote}
Seems like you should add a test or two for this change.
{quote}
added one test. this is really hard to assert the real behaviors as many are
static apis and can not access the references.
Thanks
Uma
> HA: ConfiguredFailoverProxyProvider should not create a NameNode proxy with
> an underlying retry proxy
> -----------------------------------------------------------------------------------------------------
>
> Key: HDFS-2928
> URL: https://issues.apache.org/jira/browse/HDFS-2928
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: ha, hdfs client
> Affects Versions: HA branch (HDFS-1623)
> Reporter: Aaron T. Myers
> Assignee: Uma Maheswara Rao G
> Priority: Minor
> Attachments: HDFS-2928.patch, HDFS-2928.patch
>
>
> This is to address the following TODO in ConfiguredFailoverProxyProvider:
> {quote}
> // TODO(HA): This will create a NN proxy with an underlying retry
> // proxy. We don't want this.
> {quote}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
