[ 
https://issues.apache.org/jira/browse/HDFS-17713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17936168#comment-17936168
 ] 

ASF GitHub Bot commented on HDFS-17713:
---------------------------------------

hfutatzhanghb commented on code in PR #7304:
URL: https://github.com/apache/hadoop/pull/7304#discussion_r1998617370


##########
hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/async/RouterAsyncRpcClient.java:
##########
@@ -214,45 +219,47 @@ private void invokeMethodAsync(
     final ExecutionStatus status = new ExecutionStatus(false, useObserver);
     Map<FederationNamenodeContext, IOException> ioes = new LinkedHashMap<>();
     final ConnectionContext[] connection = new ConnectionContext[1];
-    asyncForEach(namenodes.iterator(),
-        (foreach, namenode) -> {
-          if (!status.isShouldUseObserver()
-              && (namenode.getState() == 
FederationNamenodeServiceState.OBSERVER)) {
-            asyncComplete(null);
-            return;
-          }
-          String nsId = namenode.getNameserviceId();
-          String rpcAddress = namenode.getRpcAddress();
-          asyncTry(() -> {
-            connection[0] = getConnection(ugi, nsId, rpcAddress, protocol);
-            NameNodeProxiesClient.ProxyAndInfo<?> client = 
connection[0].getClient();
-            invoke(namenode, status.isShouldUseObserver(), 0, method,
+    asyncTry(() -> {
+      asyncForEach(namenodes.iterator(),

Review Comment:
   Have fixed. Thanks a lot.





> [ARR] Throtting asynchronous calls for each nameservice
> -------------------------------------------------------
>
>                 Key: HDFS-17713
>                 URL: https://issues.apache.org/jira/browse/HDFS-17713
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: rbf
>            Reporter: farmmamba
>            Assignee: farmmamba
>            Priority: Major
>              Labels: pull-request-available
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

Reply via email to