[
https://issues.apache.org/jira/browse/HDFS-2934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13208728#comment-13208728
]
Aaron T. Myers commented on HDFS-2934:
--------------------------------------
Patch largely looks good. A few small comments:
# You should amend the method comment for setGenericConf, since it now also
tries appending only the nsId, in addition to nsId.nnId.
# There's no need for the "continue" in the second if body.
Otherwise it looks good. +1 once these are addressed.
> HA: Allow configs to be scoped to all NNs in the nameservice
> ------------------------------------------------------------
>
> Key: HDFS-2934
> URL: https://issues.apache.org/jira/browse/HDFS-2934
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: ha, name-node
> Affects Versions: HA branch (HDFS-1623)
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Priority: Minor
> Attachments: hdfs-2934.txt
>
>
> Currently, for namenode-specific keys in HA, one must configure them as
> keyfoo.nameserviceid.namenodeid. However, in many cases all of the NNs in a
> nameservice would share the same value. So we should allow the configuration
> of "keyfoo.nameserviceid" to apply to all NNs. The resolution path for these
> keys would then be:
> keyfoo.nameserviceid.nnid
> keyfoo.nameserviceid (if above not set)
> keyfoo (if neither of above set)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
