[
https://issues.apache.org/jira/browse/HDFS-17766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17940211#comment-17940211
]
ASF GitHub Bot commented on HDFS-17766:
---------------------------------------
KeeProMise commented on code in PR #7561:
URL: https://github.com/apache/hadoop/pull/7561#discussion_r2023907636
##########
hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/Router.java:
##########
@@ -876,4 +878,10 @@ public void setConf(Configuration conf) {
this.conf = conf;
}
+ @VisibleForTesting
+ public boolean isAsync() {
+ return getRpcServer() != null ? getRpcServer().isAsync() :
+ getConfig() != null ?
getConfig().getBoolean(DFS_ROUTER_ASYNC_RPC_ENABLE_KEY,
+ DFS_ROUTER_ASYNC_RPC_ENABLE_DEFAULT) :
DFS_ROUTER_ASYNC_RPC_ENABLE_DEFAULT;
+ }
Review Comment:
Hi @hfutatzhanghb Can this method be deleted?
> [ARR] Avoid initializing unused threadPool in RouterAsyncRpcClient
> ------------------------------------------------------------------
>
> Key: HDFS-17766
> URL: https://issues.apache.org/jira/browse/HDFS-17766
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: rbf
> Reporter: farmmamba
> Assignee: farmmamba
> Priority: Major
> Labels: pull-request-available
>
> Avoid initializing unused threadPool in RouterAsyncRpcClient.
> This can save thread resources.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
