[
https://issues.apache.org/jira/browse/HDFS-17751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17940212#comment-17940212
]
ASF GitHub Bot commented on HDFS-17751:
---------------------------------------
KeeProMise commented on PR #7470:
URL: https://github.com/apache/hadoop/pull/7470#issuecomment-2771113332
> > Hi, @slfan1989 @KeeProMise @Hexiaoqiao . I wonder that whether should we
split this PR or not ? If all in one, it would be unfriendly for reivewing.
What's your opinions?
>
> @hfutatzhanghb Thank you for the information! I think we should first
focus on updating all the unit tests in a single pr, and then consider
splitting the changes into multiple prs afterward.
>
> I believe a single PR should not exceed 3000 lines or affect more than 50
classes. Since we're only improving unit tests and not modifying core logic,
the review effort should be manageable.
+1
> [ARR] Add unit tests using asynchronous router rpc for all in
> org.apache.hadoop.hdfs.server.federation.router
> -------------------------------------------------------------------------------------------------------------
>
> Key: HDFS-17751
> URL: https://issues.apache.org/jira/browse/HDFS-17751
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: rbf, test
> Reporter: farmmamba
> Assignee: farmmamba
> Priority: Major
> Labels: pull-request-available
>
> This Jira aims to add unit tests using asynchronous router rpc for those
> existed unit tests which in org.apache.hadoop.hdfs.server.federation.router
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
