[
https://issues.apache.org/jira/browse/HDFS-17718?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17939914#comment-17939914
]
ASF GitHub Bot commented on HDFS-17718:
---------------------------------------
slfan1989 commented on code in PR #7563:
URL: https://github.com/apache/hadoop/pull/7563#discussion_r2022181587
##########
hadoop-hdfs-project/hadoop-hdfs-client/src/test/java/org/apache/hadoop/hdfs/shortcircuit/TestShortCircuitShm.java:
##########
@@ -23,10 +23,10 @@
import org.apache.hadoop.hdfs.shortcircuit.ShortCircuitShm.Slot;
import org.apache.hadoop.io.nativeio.SharedFileDescriptorFactory;
import org.apache.hadoop.test.GenericTestUtils;
-import org.junit.Assert;
import org.junit.Assume;
Review Comment:
avoid `org.junit.Assume`
> Upgrade JUnit from 4 to 5 in hadoop-hdfs-client.
> ------------------------------------------------
>
> Key: HDFS-17718
> URL: https://issues.apache.org/jira/browse/HDFS-17718
> Project: Hadoop HDFS
> Issue Type: Improvement
> Reporter: Shilun Fan
> Assignee: Hualong Zhang
> Priority: Major
> Labels: pull-request-available
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
