[ https://issues.apache.org/jira/browse/HDFS-12431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17945791#comment-17945791 ]
ASF GitHub Bot commented on HDFS-12431: --------------------------------------- slfan1989 commented on code in PR #7626: URL: https://github.com/apache/hadoop/pull/7626#discussion_r2051213602 ########## hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestMultipleNNPortQOP.java: ########## @@ -32,16 +32,16 @@ import org.apache.hadoop.hdfs.server.datanode.DataNode; import org.apache.hadoop.io.DataInputBuffer; import org.apache.hadoop.security.token.Token; -import org.junit.Before; -import org.junit.Test; +import org.junit.jupiter.api.BeforeEach; +import org.junit.jupiter.api.Test; import static org.apache.hadoop.fs.CommonConfigurationKeysPublic.HADOOP_RPC_PROTECTION; import static org.apache.hadoop.hdfs.DFSConfigKeys.DFS_ENCRYPT_DATA_OVERWRITE_DOWNSTREAM_DERIVED_QOP_KEY; import static org.apache.hadoop.hdfs.DFSConfigKeys.DFS_NAMENODE_SERVICE_RPC_ADDRESS_KEY; import static org.apache.hadoop.hdfs.DFSConfigKeys.DFS_NAMENODE_SEND_QOP_ENABLED; import static org.apache.hadoop.hdfs.DFSConfigKeys.DFS_NAMENODE_RPC_ADDRESS_AUXILIARY_KEY; import static org.apache.hadoop.hdfs.client.HdfsClientConfigKeys.DFS_ENCRYPT_DATA_OVERWRITE_DOWNSTREAM_NEW_QOP_KEY; -import static org.junit.Assert.*; +import static org.junit.jupiter.api.Assertions.*; Review Comment: Can we expand * > Upgrade JUnit from 4 to 5 in hadoop-hdfs hdfs > ----------------------------------------------- > > Key: HDFS-12431 > URL: https://issues.apache.org/jira/browse/HDFS-12431 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: test > Reporter: Ajay Kumar > Assignee: Ashutosh Gupta > Priority: Major > Labels: pull-request-available > > Upgrade JUnit from 4 to 5 in hadoop-hdfs hdfs (i.e org.apache.hadoop.hdfs) -- This message was sent by Atlassian Jira (v8.20.10#820010) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org