[ 
https://issues.apache.org/jira/browse/HDFS-12431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17947467#comment-17947467
 ] 

ASF GitHub Bot commented on HDFS-12431:
---------------------------------------

slfan1989 commented on code in PR #7647:
URL: https://github.com/apache/hadoop/pull/7647#discussion_r2061148706


##########
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/tools/TestAdminHelper.java:
##########
@@ -28,11 +28,10 @@ public class TestAdminHelper {
   @Test
   public void prettifyExceptionWithNpe() {
     String pretty = AdminHelper.prettifyException(new NullPointerException());
-    Assert.assertTrue(
+    Assertions.assertTrue(pretty.startsWith("NullPointerException at 
org.apache.hadoop.hdfs.tools"

Review Comment:
   It is better to use static import





> Upgrade JUnit from 4 to 5 in hadoop-hdfs hdfs  
> -----------------------------------------------
>
>                 Key: HDFS-12431
>                 URL: https://issues.apache.org/jira/browse/HDFS-12431
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: test
>            Reporter: Ajay Kumar
>            Assignee: Hualong Zhang
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 3.5.0
>
>
> Upgrade JUnit from 4 to 5 in hadoop-hdfs hdfs (i.e org.apache.hadoop.hdfs)



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

Reply via email to