[
https://issues.apache.org/jira/browse/HDFS-17793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17954558#comment-17954558
]
ASF GitHub Bot commented on HDFS-17793:
---------------------------------------
Copilot commented on code in PR #7714:
URL: https://github.com/apache/hadoop/pull/7714#discussion_r2111611930
##########
hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/async/RouterAsyncClientProtocol.java:
##########
@@ -1164,4 +1167,28 @@ public Path getEnclosingRoot(String src) throws
IOException {
return asyncReturn(Path.class);
}
+ @Override
+ public Token<DelegationTokenIdentifier> getDelegationToken(Text renewer)
+ throws IOException {
+ rpcServer.checkOperation(NameNode.OperationCategory.WRITE, true);
+ asyncComplete(getSecurityManager().getDelegationToken(renewer));
+ return asyncReturn(Token.class);
Review Comment:
[nitpick] Using `asyncReturn(Token.class)` loses the generic type
information (`DelegationTokenIdentifier`). Consider an explicit cast or adding
`@SuppressWarnings("unchecked")` to make the conversion clear and safe.
```suggestion
return (Token<DelegationTokenIdentifier>) asyncReturn(Token.class);
```
##########
hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/RouterClientProtocol.java:
##########
@@ -2524,4 +2524,8 @@ public void setServerDefaultsLastUpdate(long
serverDefaultsLastUpdate) {
public RouterFederationRename getRbfRename() {
return rbfRename;
}
+
+ public RouterSecurityManager getSecurityManager() {
Review Comment:
This new public getter lacks Javadoc and audience annotations; consider
adding a brief description and an `@InterfaceAudience` tag to clarify intended
use.
> RBF: Enable the router asynchronous RPC feature to handle getDelegationToken
> request errors
> -------------------------------------------------------------------------------------------
>
> Key: HDFS-17793
> URL: https://issues.apache.org/jira/browse/HDFS-17793
> Project: Hadoop HDFS
> Issue Type: Bug
> Reporter: Xiping Zhang
> Assignee: Xiping Zhang
> Priority: Major
> Labels: pull-request-available
> Attachments: image-2025-05-27-10-58-55-652.png,
> image-2025-05-27-10-59-27-965.png, image-2025-05-27-11-04-40-734.png,
> image-2025-05-27-11-27-09-710.png
>
>
> !image-2025-05-27-10-58-55-652.png|width=1209,height=230!
> !image-2025-05-27-10-59-27-965.png!
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
