[
https://issues.apache.org/jira/browse/HDFS-12431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17959618#comment-17959618
]
ASF GitHub Bot commented on HDFS-12431:
---------------------------------------
slfan1989 commented on code in PR #7733:
URL: https://github.com/apache/hadoop/pull/7733#discussion_r2138968556
##########
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/StripedFileTestUtil.java:
##########
@@ -127,8 +126,8 @@ static void verifyStatefulRead(FileSystem fs, Path srcPath,
int fileLength,
System.arraycopy(buf, 0, result, readLen, ret);
readLen += ret;
}
- assertEquals("The length of file should be the same to write size",
fileLength, readLen);
- Assert.assertArrayEquals(expected, result);
+ assertEquals(fileLength, readLen, "The length of file should be the same
to write size");
+ Assertions.assertArrayEquals(expected, result);
Review Comment:
We should avoid importing via Assertions.*
> Upgrade JUnit from 4 to 5 in hadoop-hdfs hdfs
> -----------------------------------------------
>
> Key: HDFS-12431
> URL: https://issues.apache.org/jira/browse/HDFS-12431
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: test
> Reporter: Ajay Kumar
> Assignee: Hualong Zhang
> Priority: Major
> Labels: pull-request-available
> Fix For: 3.5.0
>
>
> Upgrade JUnit from 4 to 5 in hadoop-hdfs hdfs (i.e org.apache.hadoop.hdfs)
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
