[
https://issues.apache.org/jira/browse/HDFS-12431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18016918#comment-18016918
]
ASF GitHub Bot commented on HDFS-12431:
---------------------------------------
zhtttylz commented on code in PR #7908:
URL: https://github.com/apache/hadoop/pull/7908#discussion_r2309055927
##########
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/ha/TestXAttrsWithHA.java:
##########
@@ -105,9 +107,9 @@ public void testXAttrsTrackedOnStandby() throws Exception {
cluster.transitionToActive(1);
Map<String, byte[]> xattrs = fs.getXAttrs(path);
- Assert.assertEquals(xattrs.size(), 2);
- Assert.assertArrayEquals(value1, xattrs.get(name1));
- Assert.assertArrayEquals(value2, xattrs.get(name2));
+ Assertions.assertEquals(xattrs.size(), 2);
Review Comment:
Thank you for the review. I’ll roll out the updates soon.
##########
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/ha/TestXAttrsWithHA.java:
##########
@@ -105,9 +107,9 @@ public void testXAttrsTrackedOnStandby() throws Exception {
cluster.transitionToActive(1);
Map<String, byte[]> xattrs = fs.getXAttrs(path);
- Assert.assertEquals(xattrs.size(), 2);
- Assert.assertArrayEquals(value1, xattrs.get(name1));
- Assert.assertArrayEquals(value2, xattrs.get(name2));
+ Assertions.assertEquals(xattrs.size(), 2);
Review Comment:
Thank you for the review; I’ll roll the updates out shortly.
> Upgrade JUnit from 4 to 5 in hadoop-hdfs hdfs
> -----------------------------------------------
>
> Key: HDFS-12431
> URL: https://issues.apache.org/jira/browse/HDFS-12431
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: test
> Reporter: Ajay Kumar
> Assignee: Hualong Zhang
> Priority: Major
> Labels: pull-request-available
> Fix For: 3.5.0
>
>
> Upgrade JUnit from 4 to 5 in hadoop-hdfs hdfs (i.e org.apache.hadoop.hdfs)
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
