[
https://issues.apache.org/jira/browse/HDFS-17828?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18020351#comment-18020351
]
ASF GitHub Bot commented on HDFS-17828:
---------------------------------------
stoty commented on PR #7955:
URL: https://github.com/apache/hadoop/pull/7955#issuecomment-3292078717
> really like this. But you will need to add test cases to verify the
exception matching itself works with
>
> * regexp that doesn't parse
That is not relevant as the method already expects a Pattern, not a String.
> * null pattern
> * no pattern match
> * pattern match
Add the other tests.
However note that the both the existing and new tests for null Exceptions
are misleading, as the assertation never fails in that case.
Again, IMO those should work the same way for *Includes* and *Matches* , so
the current behaviour is at least consistent.
> SocketTimeoutException not recognized in TestWebHdfsTimeouts with Java 24
> -------------------------------------------------------------------------
>
> Key: HDFS-17828
> URL: https://issues.apache.org/jira/browse/HDFS-17828
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: hdfs, test
> Affects Versions: 3.5.0
> Reporter: Istvan Toth
> Assignee: Istvan Toth
> Priority: Major
> Labels: java24, pull-request-available
>
> Java 24 capitalizes "Connect" in th Exception message, which the test does
> not recognize.
> {noformat}
> [ERROR]
> org.apache.hadoop.hdfs.web.TestWebHdfsTimeouts.testAuthUrlConnectTimeout(TimeoutSource)[2]
> -- Time elapsed: 0.313 s <<< FAILURE!
> java.lang.AssertionError:
> Expected to find 'localhost:33473: connect timed out' but got unexpected
> exception: java.net.SocketTimeoutException: localhost:33473: Connect timed out
> at
> java.base/sun.nio.ch.NioSocketImpl.timedFinishConnect(NioSocketImpl.java:537)
> at java.base/sun.nio.ch.NioSocketImpl.connect(NioSocketImpl.java:583)
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
