[ 
https://issues.apache.org/jira/browse/HDFS-17267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18027958#comment-18027958
 ] 

ASF GitHub Bot commented on HDFS-17267:
---------------------------------------

github-actions[bot] commented on PR #6311:
URL: https://github.com/apache/hadoop/pull/6311#issuecomment-3374717778

   We're closing this stale PR because it has been open for 100 days with no 
activity. This isn't a judgement on the merit of the PR in any way. It's just a 
way of keeping the PR queue manageable.
   If you feel like this was a mistake, or you would like to continue working 
on it, please feel free to re-open it and ask for a committer to remove the 
stale tag and review again.
   Thanks all for your contribution.




> Client send the smae packet multiple times when method markSlowNode throws 
> IOException.
> ---------------------------------------------------------------------------------------
>
>                 Key: HDFS-17267
>                 URL: https://issues.apache.org/jira/browse/HDFS-17267
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>    Affects Versions: 3.3.6
>            Reporter: farmmamba
>            Assignee: farmmamba
>            Priority: Major
>              Labels: pull-request-available
>
> Since we have HDFS-16348, we can kick out SLOW node in pipeline when writing 
> data to pipeline. 
> And I think it introduced a problem, that is the same packet will be sent 
> twice or more times when we kick out SLOW node.
>  
> The flow are as below:
> 1、 DFSPacket p1 is pushed into dataQueue.
> 2、DataStreamer takes DFSPacket p1 from dataQueue.
> 3、Remove p1 from dataQueue and   push p1 into ackQueue.
> 4、sendPacket(p1).
> 5、In ResponseProcessor#run,  read pipelineAck for p1.
> 6、We meet SlOW node,  so method markSlowNode throw IOException and does not 
> execute `ackQueue.removeFirst();`.
> 7、In next loop of DataStreamer#run, we come into method 
> processDatanodeOrExternalError and execute `dataQueue.addAll(0, ackQueue);`.
> 8、the p1 will be sent repeatedly.
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to