[ 
https://issues.apache.org/jira/browse/HDFS-17320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18024723#comment-18024723
 ] 

ASF GitHub Bot commented on HDFS-17320:
---------------------------------------

github-actions[bot] commented on PR #6403:
URL: https://github.com/apache/hadoop/pull/6403#issuecomment-3368627091

   We're closing this stale PR because it has been open for 100 days with no 
activity. This isn't a judgement on the merit of the PR in any way. It's just a 
way of keeping the PR queue manageable.
   If you feel like this was a mistake, or you would like to continue working 
on it, please feel free to re-open it and ask for a committer to remove the 
stale tag and review again.
   Thanks all for your contribution.




> seekToNewSource uses ignoredNodes to get a new node other than the current 
> node.
> --------------------------------------------------------------------------------
>
>                 Key: HDFS-17320
>                 URL: https://issues.apache.org/jira/browse/HDFS-17320
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>            Reporter: Jian Zhang
>            Assignee: Jian Zhang
>            Priority: Minor
>              Labels: pull-request-available
>         Attachments: HDFS-17320.001.patch
>
>
> Currently, when using the DFSInputStream#seekToNewSource() method to obtain a 
> new datanode, the current datanode will be marked as deadnode first, thus 
> preventing the new datanode from being equal to the current datanode.
> If the current datanode is indeed a dead node, after obtaining the new 
> datanode, there is no need to mark the current datanode as a non-dead node; 
> but if the current node is not a dead node, after obtaining the new datanode, 
> the current node needs to be marked as Non-dead nodes (removed from the 
> deadnodes collection), the current implementation method has no problem with 
> its function, but it is very inelegant.
> Currently, when selecting a new datanode 
> (DFSInputStream#getBestNodeDNAddrPair), you can filter out unnecessary 
> datanodes through the parameter ignoredNodes. Therefore, we only need to pass 
> the current datanode into ignoredNodes to elegantly implement the function of 
> the seekToNewSource method.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to