[ 
https://issues.apache.org/jira/browse/HDFS-17858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18041114#comment-18041114
 ] 

ASF GitHub Bot commented on HDFS-17858:
---------------------------------------

ayushtkn commented on code in PR #8107:
URL: https://github.com/apache/hadoop/pull/8107#discussion_r2569332779


##########
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/tools/TestDFSAdmin.java:
##########
@@ -1250,6 +1250,7 @@ public void testAllDatanodesReconfig()
         any(Configuration.class))).thenReturn(changes);
 
     int result = admin.startReconfiguration("datanode", "livenodes");
+    Thread.sleep(50);
     assertThat(result).isEqualTo(0);

Review Comment:
   can we rather do LamdaTestUtils.wait for?





> Fix TestDFSAdmin#testAllDatanodesReconfig fails
> -----------------------------------------------
>
>                 Key: HDFS-17858
>                 URL: https://issues.apache.org/jira/browse/HDFS-17858
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: test
>    Affects Versions: 3.5.0
>            Reporter: caozhiqiang
>            Assignee: caozhiqiang
>            Priority: Major
>              Labels: pull-request-available
>
> TestDFSAdmin::testAllDatanodesReconfig() always failed because the last 
> startReconfiguration() need some time to finish.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to