[
https://issues.apache.org/jira/browse/HDFS-17857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18041329#comment-18041329
]
ASF GitHub Bot commented on HDFS-17857:
---------------------------------------
dlmarion commented on code in PR #8104:
URL: https://github.com/apache/hadoop/pull/8104#discussion_r2571998082
##########
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSConfigKeys.java:
##########
@@ -1199,6 +1199,10 @@ public class DFSConfigKeys extends
CommonConfigurationKeys {
"dfs.datanode.enable.fileio.fault.injection";
public static final boolean
DFS_DATANODE_ENABLE_FILEIO_FAULT_INJECTION_DEFAULT = false;
+ public static final String
DFS_DATANODE_ENABLED_OPS_FILEIO_FAULT_INJECTION_KEY =
+ "dfs.datanode.enabled.operations.fileio.fault.injection";
+ public static final String DFS_DATANODE_FILEIO_FAULT_PERCENTAGE_KEY =
+ "dfs.datanode.fileio.fault.sampling.percentage";
Review Comment:
I renamed the two properties that I added and removed the word `sampling`
from the one (it was leftover from a copy/paste). I didn't rename the first
property as I'm not sure of how the project deals with property name changes.
> Create implementation for FaultInjectorFileIoEvents
> ---------------------------------------------------
>
> Key: HDFS-17857
> URL: https://issues.apache.org/jira/browse/HDFS-17857
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: hdfs
> Reporter: Dave Marion
> Assignee: Dave Marion
> Priority: Minor
> Labels: pull-request-available
> Fix For: 3.5.0
>
>
> The existing FaultInjectorFileIoEvents methods have no implementation and the
> current implementation does not load a user supplied class that implements
> some interface. I think the only way that this could be used is for someone
> to create their own class with the same name and either insert it into the
> jar, or place a new jar at the beginning of the classpath.
> I think the existing FaultInjectorFileIoEvents class can be modified to throw
> exceptions for file I/O events.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
