[
https://issues.apache.org/jira/browse/HDFS-16037?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18041408#comment-18041408
]
ASF GitHub Bot commented on HDFS-16037:
---------------------------------------
github-actions[bot] commented on PR #3046:
URL: https://github.com/apache/hadoop/pull/3046#issuecomment-3590739517
We're closing this stale PR because it has been open for 100 days with no
activity. This isn't a judgement on the merit of the PR in any way. It's just a
way of keeping the PR queue manageable.
If you feel like this was a mistake, or you would like to continue working
on it, please feel free to re-open it and ask for a committer to remove the
stale tag and review again.
Thanks all for your contribution.
> Possible Resource Leak in
> org.apache.hadoop.hdfs.tools.offlineImageViewer#FSImageLoader
> ---------------------------------------------------------------------------------------
>
> Key: HDFS-16037
> URL: https://issues.apache.org/jira/browse/HDFS-16037
> Project: Hadoop HDFS
> Issue Type: Bug
> Reporter: Narges Shadab
> Priority: Major
> Labels: pull-request-available
> Time Spent: 20m
> Remaining Estimate: 0h
>
> We notice a possible resource leak in line
> [113|https://github.com/apache/hadoop/blob/59172ada9014f8c056f2bd37b25a26572ca643af/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/FSImageLoader.java#L113].
> {{file}} remains open if line 115 or 118 throws an IOException. We should
> define {{fin}} and {{file}} in try-with-resources.
> I've submitted a pull request to fix it.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
