[
https://issues.apache.org/jira/browse/HDFS-2929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13210749#comment-13210749
]
Aaron T. Myers commented on HDFS-2929:
--------------------------------------
Patch largely looks good, Todd. I love the tests.
Just a few little comments. +1 once these are addressed.
# Could use some comments in HAStressTestHarness, both class and method.
# I think you need to do an s/NN/DN/ in one place in the method comment for
TestPipelinesFailover#testFailoverRightBeforeCommitSynchronization.
# Some inconsistent indentation on long lines (2 vs 4 spaces) throughout the
patch.
# Why not use GenericTestUtils#assertExceptionContains instead of this:
{code}
if (t == null ||
!t.getMessage().contains("Operation category WRITE is not supported")) {
throw new RuntimeException(t);
}
{code}
# Could use a method comment on testPipelineRecoveryStress.
> HA: stress test and fixes for block synchronization
> ---------------------------------------------------
>
> Key: HDFS-2929
> URL: https://issues.apache.org/jira/browse/HDFS-2929
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: ha, name-node
> Affects Versions: HA branch (HDFS-1623)
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Priority: Critical
> Attachments: hdfs-2929.txt, hdfs-2929.txt, hdfs-2929.txt,
> hdfs-2929.txt
>
>
> We have a couple of TODOs in {{commitBlockSynchronization}} and {{syncBlock}}
> around HA. I think the current behavior may in fact be correct, but I plan to
> write a stress test / functional test for better coverage of this area.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
