[ 
https://issues.apache.org/jira/browse/HDFS-17873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18053769#comment-18053769
 ] 

ASF GitHub Bot commented on HDFS-17873:
---------------------------------------

LamiumAmplexicaule opened a new pull request, #8204:
URL: https://github.com/apache/hadoop/pull/8204

   <!--
     Thanks for sending a pull request!
       1. If this is your first time, please read our contributor guidelines: 
https://cwiki.apache.org/confluence/display/HADOOP/How+To+Contribute
       2. Make sure your PR title starts with JIRA issue id, e.g., 
'HADOOP-17799. Your PR title ...'.
   -->
   
   ### Description of PR
   
   Fix for [HDFS-17873](https://issues.apache.org/jira/browse/HDFS-17873)
   Enable credential providers for HikariDataSourceConnectionFactory and 
MySQLStateStoreHikariDataSourceConnectionFactory.
   
   ### How was this patch tested?
   
   Pass TestStateStoreMySQL, TestSQLDelegationTokenSecretManagerImpl, 
TestDFSUtil on local
   
   ### For code changes:
   
   - [x] Does the title or this PR starts with the corresponding JIRA issue id 
(e.g. 'HADOOP-17799. Your PR title ...')?
   - [ ] Object storage: have the integration tests been executed and the 
endpoint declared according to the connector-specific documentation?
   - [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?
   - [ ] If applicable, have you updated the `LICENSE`, `LICENSE-binary`, 
`NOTICE-binary` files?
   
   ### AI Tooling
   
   If an AI tool was used:
   
   - [ ] The PR includes the phrase "Contains content generated by <tool>"
         where <tool> is the name of the AI tool used.
   - [ ] My use of AI contributions follows the ASF legal policy
         https://www.apache.org/legal/generative-tooling.html




> Use a password retrieval method (e.g. conf.getPassword) in 
> HikariDataSourceConnectionFactory and 
> MySQLStateStoreHikariDataSourceConnectionFactory, similar to HttpServer2
> -------------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: HDFS-17873
>                 URL: https://issues.apache.org/jira/browse/HDFS-17873
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: rbf, security
>    Affects Versions: 3.4.2
>            Reporter: Hiroki Egawa
>            Priority: Major
>
> Currently, HikariDataSourceConnectionFactory and 
> MySQLStateStoreHikariDataSourceConnectionFactory do not use conf.getPassword 
> for retrieving passwords, unlike HttpServer2.
> In HttpServer2, passwords are retrieved via conf.getPassword, which supports 
> both plain-text configuration values and secure credential providers in a 
> unified and secure manner.
> This ticket proposes the following changes:
>  * Introduce a password retrieval mechanism equivalent to conf.getPassword in 
> HikariDataSourceConnectionFactory
>  * Apply the same mechanism to 
> MySQLStateStoreHikariDataSourceConnectionFactory
> Expected Outcome
>  * Secure credential providers can be used instead of plain-text passwords in 
> HikariDataSourceConnectionFactory and 
> MySQLStateStoreHikariDataSourceConnectionFactory



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to