[
https://issues.apache.org/jira/browse/HDFS-17372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18058345#comment-18058345
]
ASF GitHub Bot commented on HDFS-17372:
---------------------------------------
hfutatzhanghb commented on PR #6530:
URL: https://github.com/apache/hadoop/pull/6530#issuecomment-3895752249
> Agree with @ZanderXu . I think we should try not to modify namenode or
protocol. Actually, there is a trick that key update command can only appear in
the last two position of the `cmds` according to
`DatanodeManager#handleHeartbeat`, so we do not need to iterate all commands on
datanode.
@Hexiaoqiao Thanks for your reviewing. Actully, i have implemented inside
namenode in the first version. I will post it laterly.
BTW, from my observation, the loop has a little impact on the performance
of DataNode when there are large number commands(we met 10K+ and there is no
side-effect).
> KeyUpdateCommand should be processed at high priority level to avoid access
> key not update in time when meet huge many commands.
> --------------------------------------------------------------------------------------------------------------------------------
>
> Key: HDFS-17372
> URL: https://issues.apache.org/jira/browse/HDFS-17372
> Project: Hadoop HDFS
> Issue Type: Improvement
> Reporter: Haobo Zhang
> Assignee: Haobo Zhang
> Priority: Major
> Labels: pull-request-available
> Fix For: 3.5.1
>
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
