[ 
https://issues.apache.org/jira/browse/HDFS-2977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13212320#comment-13212320
 ] 

Uma Maheswara Rao G commented on HDFS-2977:
-------------------------------------------

This issue is a valid point for setting nsId. But actually we need not set the 
nsid explicitly in test code as MiniDFSNNTopology.simpleHATopology() can set 
nsID if we use it directly. So, why can't we use it? 
Currently can not use directly  MiniDFSNNTopology.simpleHATopology(), because 
of HDFS-2979. After addressing HDFS-2979, we can directly use 
MiniDFSNNTopology.simpleHATopology(), obviously with that change this test will 
not fail.

{quote}
just pointing out another problem in the same area of the code? 
{quote}
Yes, other problem in source.

{quote}
Should we commit this?
{quote}
Could you please take a look before committing this.
                
> HA: TestBalancerWithHANameNodes is failing
> ------------------------------------------
>
>                 Key: HDFS-2977
>                 URL: https://issues.apache.org/jira/browse/HDFS-2977
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: ha, test
>    Affects Versions: HA branch (HDFS-1623)
>            Reporter: Aaron T. Myers
>            Assignee: Aaron T. Myers
>         Attachments: HDFS-2977-HDFS-1623.patch
>
>
> Looks like it's passing a null nameservice ID, which I believe indicates a 
> non-HA setup.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to