[ 
https://issues.apache.org/jira/browse/HDFS-17917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18078878#comment-18078878
 ] 

ASF GitHub Bot commented on HDFS-17917:
---------------------------------------

magnuma3 opened a new pull request, #8475:
URL: https://github.com/apache/hadoop/pull/8475

   <!--
     Thanks for sending a pull request!
       1. If this is your first time, please read our contributor guidelines: 
https://cwiki.apache.org/confluence/display/HADOOP/How+To+Contribute
       2. Make sure your PR title starts with JIRA issue id, e.g., 
'HADOOP-17799. Your PR title ...'.
   -->
   
   ### Description of PR
   
   When deleting empty directory, empty list is added to markedDeleteQueue.
   I think this is unnecessary. and markedDeleteQueue.size() is O(n) operation, 
so it is costly.
   
   ### How was this patch tested?
   
   unit test
   
   ### For code changes:
   
   - [x] Does the title or this PR starts with the corresponding JIRA issue id 
(e.g. 'HADOOP-17799. Your PR title ...')?
   - [ ] Object storage: have the integration tests been executed and the 
endpoint declared according to the connector-specific documentation?
   - [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?
   - [ ] If applicable, have you updated the `LICENSE`, `LICENSE-binary`, 
`NOTICE-binary` files?
   
   ### AI Tooling
   
   If an AI tool was used:
   
   - [ ] The PR includes the phrase "Contains content generated by <tool>"
         where <tool> is the name of the AI tool used.
   - [ ] My use of AI contributions follows the ASF legal policy
         https://www.apache.org/legal/generative-tooling.html




> Fix empty block list enqueue in markedDeleteQueue
> -------------------------------------------------
>
>                 Key: HDFS-17917
>                 URL: https://issues.apache.org/jira/browse/HDFS-17917
>             Project: Hadoop HDFS
>          Issue Type: Bug
>            Reporter: KWON BYUNGCHANG
>            Priority: Minor
>         Attachments: HDFS-17917.001.patch, HDFS-17917.002.patch
>
>
> When deleting empty directory, empty list is added to markedDeleteQueue.
> I think this is unnecessary. and markedDeleteQueue.size() is O( n ) 
> operation, so it is costly.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to