[
https://issues.apache.org/jira/browse/HDFS-17934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18089585#comment-18089585
]
ASF GitHub Bot commented on HDFS-17934:
---------------------------------------
ayushtkn commented on code in PR #8540:
URL: https://github.com/apache/hadoop/pull/8540#discussion_r3426701271
##########
hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/metrics/RBFMetrics.java:
##########
@@ -379,6 +387,19 @@ public String getRouters() {
return JSON.toString(info);
}
+ private static String guessRouterWebAddress(String adminAddress, int
webPort) {
+ try {
+ if (isNullOrEmpty(adminAddress)) {
+ return "";
+ }
+ String host = adminAddress.split(":")[0];
+ return "http://"; + host + ":" + webPort;
Review Comment:
how do u know it is http only, we have ``DFS_ROUTER_HTTPS_ADDRESS_KEY`` as
well
##########
hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/metrics/RBFMetrics.java:
##########
@@ -379,6 +387,19 @@ public String getRouters() {
return JSON.toString(info);
}
+ private static String guessRouterWebAddress(String adminAddress, int
webPort) {
Review Comment:
guess isn't a very nice word here & moreover we can't rely on guesswork
either
> Add router web address to router web UI
> ---------------------------------------
>
> Key: HDFS-17934
> URL: https://issues.apache.org/jira/browse/HDFS-17934
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: hdfs, rbf
> Reporter: Felix N
> Assignee: Felix N
> Priority: Minor
> Labels: pull-request-available
>
> In router web interface, there are clickable URLs for namenodes and
> datanodes, but none for routers.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
