[
https://issues.apache.org/jira/browse/HDFS-17948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18093046#comment-18093046
]
ASF GitHub Bot commented on HDFS-17948:
---------------------------------------
hadoop-yetus commented on PR #8579:
URL: https://github.com/apache/hadoop/pull/8579#issuecomment-4859311115
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|:----:|----------:|--------:|:--------:|:-------:|
| +0 :ok: | reexec | 0m 35s | | Docker mode activated. |
|||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | | No case conflicting files
found. |
| +0 :ok: | codespell | 0m 0s | | codespell was not available. |
| +0 :ok: | detsecrets | 0m 0s | | detect-secrets was not available.
|
| +0 :ok: | xmllint | 0m 0s | | xmllint was not available. |
| +0 :ok: | markdownlint | 0m 0s | | markdownlint was not available.
|
| +1 :green_heart: | @author | 0m 0s | | The patch does not contain
any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | | The patch appears to
include 2 new or modified test files. |
|||| _ trunk Compile Tests _ |
| +0 :ok: | mvndep | 309m 34s | | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 56m 58s | | trunk passed |
| +1 :green_heart: | compile | 8m 35s | | trunk passed with JDK
Ubuntu-21.0.11+10-1-24.04.2-Ubuntu |
| +1 :green_heart: | compile | 8m 42s | | trunk passed with JDK
Ubuntu-17.0.19+10-1-24.04.2-Ubuntu |
| +1 :green_heart: | checkstyle | 3m 5s | | trunk passed |
| +1 :green_heart: | mvnsite | 1m 31s | | trunk passed |
| +1 :green_heart: | javadoc | 1m 15s | | trunk passed with JDK
Ubuntu-21.0.11+10-1-24.04.2-Ubuntu |
| +1 :green_heart: | javadoc | 1m 13s | | trunk passed with JDK
Ubuntu-17.0.19+10-1-24.04.2-Ubuntu |
| -1 :x: | spotbugs | 0m 43s |
[/branch-spotbugs-hadoop-tools_hadoop-federation-balance-warnings.html](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8579/1/artifact/out/branch-spotbugs-hadoop-tools_hadoop-federation-balance-warnings.html)
| hadoop-tools/hadoop-federation-balance in trunk has 12 extant spotbugs
warnings. |
| +1 :green_heart: | shadedclient | 15m 42s | | branch has no errors
when building and testing our client artifacts. |
|||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 16s | | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 0m 48s | | the patch passed |
| +1 :green_heart: | compile | 8m 6s | | the patch passed with JDK
Ubuntu-21.0.11+10-1-24.04.2-Ubuntu |
| +1 :green_heart: | javac | 8m 6s | | the patch passed |
| +1 :green_heart: | compile | 8m 37s | | the patch passed with JDK
Ubuntu-17.0.19+10-1-24.04.2-Ubuntu |
| +1 :green_heart: | javac | 8m 37s | | the patch passed |
| +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks
issues. |
| +1 :green_heart: | checkstyle | 2m 59s | | the patch passed |
| +1 :green_heart: | mvnsite | 1m 30s | | the patch passed |
| -1 :x: | javadoc | 0m 34s |
[/results-javadoc-javadoc-hadoop-tools_hadoop-federation-balance-jdkUbuntu-21.0.11+10-1-24.04.2-Ubuntu.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8579/1/artifact/out/results-javadoc-javadoc-hadoop-tools_hadoop-federation-balance-jdkUbuntu-21.0.11+10-1-24.04.2-Ubuntu.txt)
|
hadoop-tools_hadoop-federation-balance-jdkUbuntu-21.0.11+10-1-24.04.2-Ubuntu
with JDK Ubuntu-21.0.11+10-1-24.04.2-Ubuntu generated 6 new + 97 unchanged - 0
fixed = 103 total (was 97) |
| -1 :x: | javadoc | 0m 35s |
[/results-javadoc-javadoc-hadoop-tools_hadoop-federation-balance-jdkUbuntu-17.0.19+10-1-24.04.2-Ubuntu.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8579/1/artifact/out/results-javadoc-javadoc-hadoop-tools_hadoop-federation-balance-jdkUbuntu-17.0.19+10-1-24.04.2-Ubuntu.txt)
|
hadoop-tools_hadoop-federation-balance-jdkUbuntu-17.0.19+10-1-24.04.2-Ubuntu
with JDK Ubuntu-17.0.19+10-1-24.04.2-Ubuntu generated 6 new + 93 unchanged - 0
fixed = 99 total (was 93) |
| +1 :green_heart: | spotbugs | 2m 23s | | the patch passed |
| +1 :green_heart: | shadedclient | 16m 40s | | patch has no errors
when building and testing our client artifacts. |
|||| _ Other Tests _ |
| +1 :green_heart: | unit | 1m 59s | | hadoop-federation-balance in
the patch passed. |
| +1 :green_heart: | unit | 37m 58s | | hadoop-hdfs-rbf in the patch
passed. |
| +1 :green_heart: | asflicense | 0m 44s | | The patch does not
generate ASF License warnings. |
| | | 500m 20s | | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.55 ServerAPI=1.55 base:
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8579/1/artifact/out/Dockerfile
|
| GITHUB PR | https://github.com/apache/hadoop/pull/8579 |
| Optional Tests | dupname asflicense compile javac javadoc mvninstall
mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets xmllint
markdownlint |
| uname | Linux bf9e176846ad 5.15.0-181-generic #191-Ubuntu SMP Fri May 22
19:09:02 UTC 2026 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/bin/hadoop.sh |
| git revision | trunk / 53b09e0cc4c0a52f8634da5c2a2e502055110f5b |
| Default Java | Ubuntu-17.0.19+10-1-24.04.2-Ubuntu |
| Multi-JDK versions |
/usr/lib/jvm/java-21-openjdk-amd64:Ubuntu-21.0.11+10-1-24.04.2-Ubuntu
/usr/lib/jvm/java-17-openjdk-amd64:Ubuntu-17.0.19+10-1-24.04.2-Ubuntu |
| Test Results |
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8579/1/testReport/ |
| Max. process+thread count | 4150 (vs. ulimit of 10000) |
| modules | C: hadoop-tools/hadoop-federation-balance
hadoop-hdfs-project/hadoop-hdfs-rbf U: . |
| Console output |
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8579/1/console |
| versions | git=2.43.0 maven=3.9.15 spotbugs=4.9.7 |
| Powered by | Apache Yetus 0.14.1 https://yetus.apache.org |
This message was automatically generated.
> Improve FedBalance DistCp option handling
> -----------------------------------------
>
> Key: HDFS-17948
> URL: https://issues.apache.org/jira/browse/HDFS-17948
> Project: Hadoop HDFS
> Issue Type: Improvement
> Reporter: QI, Jiale
> Priority: Minor
> Labels: pull-request-available
>
> FedBalance currently submits DistCp jobs with a fixed set of DistCp preserve
> options and does not expose several useful DistCp knobs through the
> FedBalance CLI.
> This makes FedBalance less flexible for operators. For example:
> - ACL preservation is always requested by the generated DistCp command, which
> can fail or be undesirable when ACLs are not enabled on one side.
> - File timestamp preservation cannot be requested explicitly.
> - DistCp copy strategy cannot be selected through FedBalance.
> - DistCp listStatus parallelism cannot be tuned through FedBalance.
> - `-diffThreshold` is documented but not registered in the shared CLI options.
> This issue proposes adding FedBalance options for these DistCp settings while
> keeping the existing default behavior as much as possible:
> - Add `-skipAclPreserve` to disable ACL preservation.
> - Preserve ACLs only when both source and destination filesystems support
> ACLs.
> - Add `hdfs.fedbalance.preserve.acl.enabled` as a configuration-level ACL
> preserve switch.
> - Add `-preserveTimes` to include file timestamp preservation.
> - Add `-distcpStrategy` to pass a DistCp copy strategy.
> - Add `-numListstatusThreads` to tune DistCp listStatus threads.
> - Register `-diffThreshold` in the shared CLI option set.
> - Persist the new options in `FedBalanceContext` so recovered jobs keep the
> same behavior.
> Defaults should remain conservative: ACL preservation stays enabled when
> supported by both sides, timestamp preservation remains disabled unless
> requested, and DistCp strategy/listStatus thread settings use DistCp defaults
> unless explicitly configured.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
