[
https://issues.apache.org/jira/browse/HDFS-17872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18094163#comment-18094163
]
ASF GitHub Bot commented on HDFS-17872:
---------------------------------------
Hexiaoqiao commented on code in PR #8335:
URL: https://github.com/apache/hadoop/pull/8335#discussion_r3533316942
##########
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/diskbalancer/command/PlanCommand.java:
##########
@@ -250,11 +250,16 @@ static private void printToScreen(List<NodePlan> plans) {
}
/**
- * Sets user specified plan parameters.
+ * Sets user specified plan parameters (bandwidth, maxError,
tolerancePercent).
+ * tolerancePercent is read from config so the plan propagated to the
DataNode
+ * uses the same value (HDFS-17872).
*
* @param plans - list of plans.
*/
private void setPlanParams(List<NodePlan> plans) {
+ int tolerancePercent = getConf().getInt(
Review Comment:
We need to check if `tolerancePercent` is not greater than 0 here. Others
looks good to me.
> DiskBalancer: Plan command support with tolerancePercentage.
> ------------------------------------------------------------
>
> Key: HDFS-17872
> URL: https://issues.apache.org/jira/browse/HDFS-17872
> Project: Hadoop HDFS
> Issue Type: Improvement
> Reporter: fuchaohong
> Priority: Major
> Labels: pull-request-available
>
> dfs.disk.balancer.block.tolerance.percent
> {code:java}
> The tolerance percent specifies when we have reached a good enough value for
> any copy step. For example, if you specify 10% then getting close to 10% of
> the target value is good enough.{code}
> Currently, only *{{maxDiskErrors}}* and *{{bandwidth}}* are passed in the
> plan, and it is expected that *{{tolerancePercentage}}* can also be
> propagated to the DataNode.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
