[ 
https://issues.apache.org/jira/browse/HDFS-2958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13218355#comment-13218355
 ] 

Eli Collins commented on HDFS-2958:
-----------------------------------

+1 looks great. This is much nicer! I tried to see if we could replace the big 
if statement in createNonHAProxy with a single method and have protocols 
override a proxy creation method but what I think you have here is better.
                
> HA: Sweep for remaining proxy construction which doesn't go through failover 
> path
> ---------------------------------------------------------------------------------
>
>                 Key: HDFS-2958
>                 URL: https://issues.apache.org/jira/browse/HDFS-2958
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: ha
>    Affects Versions: HA branch (HDFS-1623)
>            Reporter: Todd Lipcon
>            Assignee: Aaron T. Myers
>         Attachments: HDFS-2958-HDFS-1623.patch
>
>
> There seem to be a couple more places where we construct proxies without 
> going through the failover code path. In particular I just tried "hdfs 
> groups" and it didn't properly resolve the logical URI. There may be others.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to