[ 
https://issues.apache.org/jira/browse/HDFS-3026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13218753#comment-13218753
 ] 

Eli Collins commented on HDFS-3026:
-----------------------------------

bq. bq. Wrt delayed shutdown, we likely have (or should have) similar code 
elsewhere right since there's nothing HA specific?
bq. Not sure quite what you mean by this. Like where?

We have other paths where a failure to start/stop services hooks into NN 
shutdown (the NameNode constructor exceptions caught by NameNode#main, and 
NameNode#stop), was thinking we could re-use those, but I forgot that these 
transitions you're worried about are triggered by RPC, which is, duh, why 
you're delaying shutdown.

Rather than waiting N seconds and running the NN in an ill-defined state which 
will handle requests, seems like it would be better flag that the NN shutdown 
on reply to the RPC, and the shutdown path attempt NN#stop vs exiting hard. 
Would be useful for other non-HA cases where we discover in RPC context that 
we'd like to shutdown. Agree?
                
> HA: Handle failure during HA state transition
> ---------------------------------------------
>
>                 Key: HDFS-3026
>                 URL: https://issues.apache.org/jira/browse/HDFS-3026
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: ha, name-node
>    Affects Versions: HA branch (HDFS-1623)
>            Reporter: Aaron T. Myers
>            Assignee: Aaron T. Myers
>         Attachments: HDFS-3026-HDFS-1623.patch
>
>
> This JIRA is to address a TODO in NameNode about handling the possibility of 
> an incomplete HA state transition.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to