[ 
https://issues.apache.org/jira/browse/HDFS-309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13218823#comment-13218823
 ] 

Todd Lipcon commented on HDFS-309:
----------------------------------

{code}
+    LOG.info("Acquiring write lock to replay edit log");
+
{code}
seems like it should be a TRACE, or just deleted.

----
- {{numOfTxs}} - please rename to {{numTxns}} to match style used elsewhere
- similary, {{currentTx}} should be {{currentTxId}}

----
{code}
+          // replay progress log
{code}
- I think better to write "log progress"


- Is it possible to somehow find the path of the log being replayed? I think 
the EditLogInputStream should stringify itself correctly. This way we could 
include the path in the log output, which is helpful since there may be 
multiple segments that need to be replayed.

                
> FSEditLog should log progress during replay
> -------------------------------------------
>
>                 Key: HDFS-309
>                 URL: https://issues.apache.org/jira/browse/HDFS-309
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>            Reporter: Todd Lipcon
>            Assignee: Sho Shimauchi
>              Labels: newbie
>         Attachments: HDFS-309.txt, HDFS-309.txt
>
>
> When the NameNode is replaying a long edit log, it's handy to have reports on 
> how far through it is, so you can judge how much time it is remaining.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to