[ 
https://issues.apache.org/jira/browse/HDFS-2303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13224764#comment-13224764
 ] 

Eli Collins commented on HDFS-2303:
-----------------------------------

Agree w Tucu, Mingjie, Roman, ATM, on the approach.
 
Mingjie, your latest patch looks good to me. Minor comments:
- Would it be better to set JSVC_HOME rather than require it be on the path?
- Nit: "node. But" -> "node, but"
- In the error message I'd explicitly mention a specific version of jsvc 
(1.0.5) and download link: 
"http://archive.apache.org/dist/commons/daemon/binaries/<version>/<platform>/"
- We need to make a minor update to deployment_layout.xml in common, can do 
that separately

Thanks,
Eli

                
> jsvc needs to be recompilable
> -----------------------------
>
>                 Key: HDFS-2303
>                 URL: https://issues.apache.org/jira/browse/HDFS-2303
>             Project: Hadoop HDFS
>          Issue Type: Bug
>            Reporter: Roman Shaposhnik
>            Assignee: Roman Shaposhnik
>         Attachments: HDFS-2303-2.patch.txt, HDFS-2303-3-trunk.patch, 
> HDFS-2303.patch.txt
>
>
> It would be nice to recompile jsvc as part of the native profile. This has a 
> number of benefits including an ability to re-generate all binary artifacts, 
> etc. Most of all, however, it will provide a way to generate jsvc on Linux 
> distributions that don't have matching libc

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to