[ 
https://issues.apache.org/jira/browse/HDFS-1512?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13226787#comment-13226787
 ] 

Tsz Wo (Nicholas), SZE commented on HDFS-1512:
----------------------------------------------

> @Nicholas, since you are the Author for HDFS-2862, could you please comment 
> on this point?

- Please don't cast it to FSDataset and change the interface if necessary.

- The use of getReplica(..) in BlockSender cannot easily be removed.  It is not 
a public API.  We could have removed it directly.  This simple patch won't work 
as indicated by the unit test results.  I think it needs a bigger change of the 
code.
                
> BlockSender calls deprecated method getReplica
> ----------------------------------------------
>
>                 Key: HDFS-1512
>                 URL: https://issues.apache.org/jira/browse/HDFS-1512
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: data-node
>            Reporter: Eli Collins
>            Assignee: Amin Bandeali
>              Labels: newbie
>         Attachments: HDFS-1512.patch, HDFS-1512.patch
>
>
> HDFS-680 deprecated FSDatasetInterface#getReplica, however it is still used 
> by BlockSender which still maintains a Replica member.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to