[
https://issues.apache.org/jira/browse/HDFS-3127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13236259#comment-13236259
]
Aaron T. Myers commented on HDFS-3127:
--------------------------------------
Patch largely looks good, Brandon. A few comments:
# removeStorageAccess, restoreAccess, and numStorageDirs can all be made private
# numStorageDirs can be made static
# Rather than do set(Readable/Executable/Writable), use FileUtil.chmod(...).
# Please put the contents of the test in a try/finally, with the calls to
shutdown the cluster and the 2NN in the finally block.
# Some lines are over 80 chars.
# No need for the numDatanodes variable - it's only used in one place.
# Instead of "xwr" use "rwx", which I think is a more common way of describing
permissions.
> failure in recovering removed storage directories should not stop checkpoint
> process
> ------------------------------------------------------------------------------------
>
> Key: HDFS-3127
> URL: https://issues.apache.org/jira/browse/HDFS-3127
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: name-node
> Affects Versions: 1.1.0
> Reporter: Brandon Li
> Assignee: Brandon Li
> Attachments: HDFS-3127.branch-1.patch, HDFS-3127.branch-1.patch
>
>
> When a restore fails, rollEditLog() also fails even if there are healthy
> directories. Any exceptions from recovering the removed directories should
> not fail checkpoint process.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
