[
https://issues.apache.org/jira/browse/HDFS-3089?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13238762#comment-13238762
]
Tsz Wo (Nicholas), SZE commented on HDFS-3089:
----------------------------------------------
Hi Uma, thanks for the review.
For 1), I removed it since VolumeChoosingPolicy is annotated as private like
BlockPlacementPolicy. So it should not be in hdfs-default.xml, which should
contain only public APIs. Advanced users could add this property if they want.
For 2), we actually do not yet have a consistent naming convention. For
examples, we have FsPermission, FsStatus, FsShell, FsServerDefaults,
o.a.h.f.FsConstants, etc. but also FSDataInputStream, FSDataOutputStream,
FSNamesystem, FSImage, etc. We had [a
discussion|https://issues.apache.org/jira/browse/HDFS-245?focusedCommentId=12637296&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-12637296]
and I filed HADOOP-4357 some time back. Most public APIs use FsXxx. I think
that FsXxx is preferred over FSXxx. So new classes should be named FsXxx
instead.
> Move FSDatasetInterface and other related classes/interfaces to a package
> -------------------------------------------------------------------------
>
> Key: HDFS-3089
> URL: https://issues.apache.org/jira/browse/HDFS-3089
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: data-node
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Tsz Wo (Nicholas), SZE
> Attachments: h3089_20120316_svn_mv.patch, h3089_20120319.patch,
> h3089_20120319_svn_mv.patch, h3089_20120321.patch, h3089_20120321b.patch,
> h3089_20120321b_svn_mv.patch, svn_mv.sh
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
