[
https://issues.apache.org/jira/browse/HDFS-3137?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tsz Wo (Nicholas), SZE updated HDFS-3137:
-----------------------------------------
Component/s: name-node
Nice cleanup! Some comments:
- Could you keep and revise the following comments? Othwerwise, it is not easy
to see what the code is doing.
{code}
//DataStorage
- //If upgrading from a relatively new version, we only need to create
- //links with the same filename. This can be done in bulk (much faster).
{code}
{code}
//FSImageSerialization
- // These locations are not used at all
{code}
- Should OP_DATANODE_ADD, OP_DATANODE_REMOVE and the classes be removed?
- Replace
{code}
//FSImageFormat
+ PermissionStatus permissions = namesystem.getUpgradePermission();
+ permissions = PermissionStatus.read(in);
{code}
with
{code}
+ PermissionStatus permissions = PermissionStatus.read(in);
{code}
remove
{code}
//FSEditLogLoader
PermissionStatus permissions = fsNamesys.getUpgradePermission();
if (addCloseOp.permissions != null) {
permissions = addCloseOp.permissions;
}
{code}
and then remove FSNamesystem.getUpgradePermission().
- FSImageFormat.readNumFiles(..) only has one line. Let's remove it?
{code}
private long readNumFiles(DataInputStream in)
throws IOException {
- int imgVersion = getLayoutVersion();
-
- if (LayoutVersion.supports(Feature.NAMESPACE_QUOTA, imgVersion)) {
- return in.readLong();
- } else {
- return in.readInt();
- }
+ return in.readLong();
}
{code}
> Bump LAST_UPGRADABLE_LAYOUT_VERSION
> -----------------------------------
>
> Key: HDFS-3137
> URL: https://issues.apache.org/jira/browse/HDFS-3137
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: name-node
> Reporter: Eli Collins
> Assignee: Eli Collins
> Attachments: hdfs-3137.txt, hdfs-3137.txt
>
>
> LAST_UPGRADABLE_LAYOUT_VERSION is currently -7, which corresponds to Hadoop
> 0.14. How about we bump it to -16, which corresponds to Hadoop 0.18?
> I don't think many people are using releases older than v0.18, and those who
> are probably want to upgrade to the latest stable release (v1.0). To upgrade
> to eg 0.23 they can still upgrade to v1.0 first and then upgrade again from
> there.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
